Skip to content

Conversation

@lekterable
Copy link

@lekterable lekterable commented Jun 26, 2024

Changes made to README.md have first removed and then brought code bits to README, but "Adding new modifiers" section was lost somewhere along the way,

I find it pretty important as it encourages customization + it also broke one answer to an old issue which actually lead me here: #52 (comment)

I simply propose to bring it back

@vercel
Copy link

vercel bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwindcss-typography ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2024 10:33pm

@lekterable
Copy link
Author

Hi @philipp-spiess, sorry for tagging you, but this has been open for some time now and looking at the reaction quite a few people found it important. Do you think we could merge it? Thanks!

@philipp-spiess
Copy link
Contributor

Hey @lekterable! Appreciate the PR and yeah agree that this has been open for too long.

I also don't fully understand how this section is different than that one: https://github.com/tailwindlabs/tailwindcss-typography?tab=readme-ov-file#customizing-the-css It also mentions this at the end:

Customizations should be applied to a specific modifier like DEFAULT or xl, and must be added under the css property.

I guess if we want we could just mention that you can also use this to add new modifiers but I'm not sure how often you'd need that so I'm instead going to say no for now, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants